Skip to content

Conversation

caseyclements
Copy link
Collaborator

Adding work done together with @ranfysvalle02 (@fabian) on the Autogen framework.

As usual, we are pointing to the feature branch until it is merged. The upstream maintainers have been very responsive.

@caseyclements caseyclements changed the title Python-4506 Add autogen PYTHON-4506 Add autogen Jun 24, 2024
Copy link
Collaborator

@Jibola Jibola left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

Having the feature branch is a great addition. :)

autogen/run.sh Outdated
Comment on lines 1 to 23
#!/bin/sh

# Sets up a virtual environment
# Runs the mongodb tests of the upstream repo
# NOTE: In this instance, the tests *programmtically* create_vector_search_index

set -x

. $workdir/src/.evergreen/utils.sh
PYTHON_BINARY=$(find_python3)
$PYTHON_BINARY -c "import sys; print(f'Python version found: {sys.version_info}')"

# Create and activate an isolated python venv environment
$PYTHON_BINARY -m venv venv
source venv/bin/activate
# Install autogen with extras
$PYTHON_BINARY -m pip install .[test,"retrievechat-mongodb"]


# Run tests. Sensitive variables in Evergreen come from Evergreen project: ai-ml-pipeline-testing/
MONGODB_URI=$autogen_mongodb_uri \
MONGODB_DATABASE="autogen_test_db" \
py.test -v test/agentchat/contrib/vectordb/test_mongodb.py No newline at end of file
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As an aside:

A lot of this set-up seems easily reproducible. Is it at all worth it to consolidate this script into a singular function?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nah. It's simple and clean and everyone hates writing bash. :)

@Jibola Jibola self-requested a review June 24, 2024 18:19
Copy link
Collaborator

@Jibola Jibola left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just saw this error

[2024/06/24 14:03:37.639] + py.test -v test/agentchat/contrib/vectordb/test_mongodb.py
[2024/06/24 14:03:37.639] ../run.sh: line 21: py.test: command not found

@caseyclements caseyclements requested a review from Jibola June 24, 2024 21:09
@caseyclements caseyclements merged commit 52db18d into main Jul 1, 2024
@Jibola Jibola deleted the PYTHON-4506-autogen branch October 2, 2024 18:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants